B018 to detect useless-statements at all levels #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O, I was literally about to release a new version. Will see how CI likes this and review soon. |
r-downing
commented
Dec 2, 2023
| @@ -1164,31 +1163,30 @@ def check_for_b903(self, node): | |||
| self.errors.append(B903(node.lineno, node.col_offset)) | |||
|
|
|||
| def check_for_b018(self, node): | |||
There was a problem hiding this comment.
this is mostly the same - just removing the toplevel for loop and de-indenting, renaming loopvar subnode to node. Can turn on "ignore-whitespace" option on PR view for easier review
cooperlees
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The B018 useless-statement checker was only running at the top level of modules, classes, and functions. This meant that it wouldn't detect things inside any nested blocks - e.g.
if,for,while,try, etc. Did a minor refactor to make the checker run during the basic visit function so it hits things in all scopes.Example. See added test file for more