add pre-commit config file #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we want to blacken the test files for now, it moves the comments around too much. |
|
Should we also remove the separate black and isort checks from the CI, like we did over at typeshed? (python/typeshed#6376) |
Akuli
reviewed
Jan 22, 2022
| combine_as_imports = true |
There was a problem hiding this comment.
I'm surprised that this isn't the default behavior.
|
We should also update the section on running tests in CONTRIBUTING, but that can be done in a separate PR. |
AlexWaygood
reviewed
Jan 22, 2022
|
Everything seems to be working now so I'm merging :) Thanks @JelleZijlstra! |
This was referenced Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also gitignore vscode so my git status is clean.
The config file was copied from typeshed with fixes to some paths.
Refs #128