Fix bug where Y019 was not emitted on methods that use PEP-695 TypeVars #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Jun 19, 2023
Comment on lines
+43
to
+44
| def __new__[S](cls: type[S], *args: Any, **kwargs: Any) -> S: ... # Y019 Use "typing_extensions.Self" instead of "S", e.g. "def __new__(cls, *args: Any, **kwargs: Any) -> Self: ..." | ||
| def generic_instance_method[S](self: S) -> S: ... # Y019 Use "typing_extensions.Self" instead of "S", e.g. "def generic_instance_method(self) -> Self: ..." |
There was a problem hiding this comment.
Y019 is not emitted on these two methods on main
|
This change has no effect on typeshed. 🤖🎉 |
JelleZijlstra
approved these changes
Jun 19, 2023
charliermarsh
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Aug 3, 2023
) ## Summary Implements `Y019` from [flake8-pyi](https://github.com/PyCQA/flake8-pyi). The rule checks if - instance methods that return `self` - class methods that return an instance of `cls` - `__new__` methods Return a custom `TypeVar` instead of `typing.Self` and raises a violation if this is the case. The rule also covers [PEP-695](https://peps.python.org/pep-0695/) syntax as introduced in upstream in PyCQA/flake8-pyi#402 ## Test Plan Added fixtures with test cases from upstream implementation (plus additional one for an excluded edge case, mentioned in upstream implementation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a lot more tests that use PEP-695 syntax. Closes #391.