Use newer uv features to simplify some CI jobs #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
looks like it cuts about 5s off the CI times for darwin/linux, and about 10s off the CI times for Windows. |
AlexWaygood
commented
Sep 23, 2024
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Sep 23, 2024
|
This change has no effect on typeshed. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl--pythonflag touv run)A (subjective) downside of using
uv runto run these commands in CI is that if you just copy-and-paste the commands from the GitHub workflow and run them locally, it creates auv.lockfile (so you have a dirty commit history). I don't really feel like we particularly need a lockfile for this project -- it feels like it would just add complications without really giving us anything -- so I'm not sure I'd want to commit auv.lockfile into this repo. (Others might feel differently.)