Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle exclude patterns in git_hook #1

Closed
wants to merge 2 commits into from
Closed

Correctly handle exclude patterns in git_hook #1

wants to merge 2 commits into from

Conversation

mpenkov
Copy link
Contributor

@mpenkov mpenkov commented Nov 11, 2014

The git hook wasn't handling exclude patterns correctly. This commit fixes that problem.

@sigmavirus24
Copy link
Member

Hey. Sorry it's taken me over a month to get to this but I didn't notice you had submitted it.

Can you give me an example of an exclude pattern that this fixes so I can test this locally? Also, I'm going to close and reopen this to trigger CI. If you can write a test case for this, that would be awesome. If you can't, no worries, but an example of the pattern would be sincerely appreciated.

@mpenkov
Copy link
Contributor Author

mpenkov commented Feb 7, 2015

Sorry it's taken me so long to reply. I've added some unit tests. I'll make another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants