Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted list of config filename so that it can be overriden #1634

Closed
wants to merge 2 commits into from

Conversation

wieczorek1990
Copy link

Please see related:
csachs/pyproject-flake8#14

@sadikkuzu
Copy link

Hi @wieczorek1990

I may miss something.
What is the difference between:

for candidate in ("setup.cfg", "tox.ini", ".flake8"):

and

CONFIG_FILENAMES = ("setup.cfg", "tox.ini", ".flake8")
for candidate in CONFIG_FILENAMES:

?

Thanks, have a nice day.

@wieczorek1990
Copy link
Author

This way some other package can extend the list. No easy way to extend a tuple used in a function.
Same usage before version 5:
https://github.com/csachs/pyproject-flake8/blob/main/pflake8/__init__.py#L57

@asottile
Copy link
Member

asottile commented Aug 1, 2022

monkeypatching is not supported

@asottile asottile closed this Aug 1, 2022
@PyCQA PyCQA locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants