-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing scope_type
positional argument for ScopeConsumer
#358
Comments
Just an update on this ticket : I have a fix in the master branch, however another change in pylint 2.13 requires some changes to how pylint-django runs tests. |
…on a default which is not packaged. Because #358 is imporant, for now pylint-django will just monkey-patch the lint_module_test module to a local test pylintrc
We should probably package this 😄 Hopefully I remember to do this. |
Ok, 2.5.3 is on PyPI now with the fix in despite |
@DanielNoord would you like me to open an issue ? By packaging do you mean we package the default pylintrc file in |
The specific problem I ran in to was from here - https://github.com/PyCQA/pylint/blob/main/pylint/testutils/lint_module_test.py#L48 - the I'd say that it should be packaged if "LintModuleTest" is considered a public API, but if not then it's an internal thing again and external plugins should handle it themselves; however with some kind of way to do it without monkeypatching the module as I did. |
I think it is required as we expose our functional test framework specifically for your use case: allow testing pylint plugins like we test the main checker. I'm no setup tools expert and don't have much time this weekend, so if somebody finds the time to open a PR please do so. |
You may see stack-traces containing things like:
To fix this, pylint-django needs to add backwards/forwards compatibility for ScopeConsumer
See the original issue here - pylint-dev/pylint#5970 (comment)
Pylint 2.13 changed the shape of the ScopeConsumer tuple so pylint-django needs to handle that.
The text was updated successfully, but these errors were encountered: