Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Requirements Update #356

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

edx-requirements-bot
Copy link
Contributor

Python requirements update. Please review the changelogs for the upgraded packages.

@edx-requirements-bot edx-requirements-bot requested a review from a team March 25, 2022 02:38
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #356 (df67706) into master (e8dc7bf) will not change coverage.
The diff coverage is n/a.

❗ Current head df67706 differs from pull request most recent head 505bd64. Consider uploading reports for the commit 505bd64 to get more accurate results

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          28       28           
  Lines        3004     3004           
  Branches      240      240           
=======================================
  Hits         2836     2836           
  Misses        150      150           
  Partials       18       18           
Flag Coverage Δ
unittests 94.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8dc7bf...505bd64. Read the comment docs.

@UsamaSadiq UsamaSadiq force-pushed the jenkins/upgrade-python-requirements-e8dc7bf branch from 0fa6c6c to 92159ff Compare March 25, 2022 12:48
@Ali-D-Akbar
Copy link
Contributor

There are some problems going on with pylint-django with the major version bump of Pylint. Until that is resolved, I'm going to pin pylint.

Copy link
Contributor

@Ali-D-Akbar Ali-D-Akbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UsamaSadiq please take a look at it too.

@UsamaSadiq
Copy link
Member

UsamaSadiq commented Mar 25, 2022

@Ali-D-Akbar Seems like the conflict between pylint==2.13.0 and pylint-django has just been fixed and a new version for pylint-djang==2.5.3 has been released with the fix.
See the details in the issue pylint-dev/pylint-django#358.

Let's remove the pin once and see if the issue has been resolved. If not, then we'll probably need to pin pylint version across all edX repos so I'll add the constraint in the common_constraints instead.

@Ali-D-Akbar Ali-D-Akbar force-pushed the jenkins/upgrade-python-requirements-e8dc7bf branch from df67706 to 505bd64 Compare March 28, 2022 06:30
@Ali-D-Akbar Ali-D-Akbar merged commit 35acea0 into master Mar 28, 2022
@Ali-D-Akbar Ali-D-Akbar deleted the jenkins/upgrade-python-requirements-e8dc7bf branch March 28, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants