Add urlpatterns to good_names instead of modifying const_rgx for com… #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patiblity with pylint 1.8+
atodorov
pushed a commit
to MrSenko/django-pylint
that referenced
this pull request
Jan 17, 2018
for compatiblity with pylint 1.8+ Fixes pylint-dev#108 Original PR: pylint-dev#109 Obsolete PR: pylint-dev#111
atodorov
pushed a commit
to MrSenko/django-pylint
that referenced
this pull request
Jan 17, 2018
for compatiblity with pylint 1.8+ Fixes pylint-dev#108 Original PR: pylint-dev#109 Obsolete PR: pylint-dev#111
atodorov
pushed a commit
to MrSenko/django-pylint
that referenced
this pull request
Jan 18, 2018
for compatiblity with pylint 1.8+ Fixes pylint-dev#108 Original PR: pylint-dev#109 Obsolete PR: pylint-dev#111
atodorov
pushed a commit
to MrSenko/django-pylint
that referenced
this pull request
Jan 18, 2018
for compatiblity with pylint 1.8+ Fixes pylint-dev#108 Original PR: pylint-dev#109 Obsolete PR: pylint-dev#111
atodorov
pushed a commit
to MrSenko/django-pylint
that referenced
this pull request
Jan 18, 2018
for compatiblity with pylint 1.8+ Fixes pylint-dev#108 Original PR: pylint-dev#109 Obsolete PR: pylint-dev#111
|
Merged manually as part of #113, thanks. |
|
Looks like after this change is impossible to add custom good names to the own configuration. Following snippet is always reporting urlpatterns and so and when I remove own good names, then logger is reported instead. Before it was working together fine (version 0.7.2). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add common names to good_names instead of modifying const_rgx for compatiblity with pylint 1.8+
Fixes #108