Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly mark raw strings (used as regex) #51

Merged
merged 1 commit into from
Jan 21, 2018
Merged

properly mark raw strings (used as regex) #51

merged 1 commit into from
Jan 21, 2018

Conversation

asherf
Copy link
Contributor

@asherf asherf commented Jan 14, 2018

No description provided.

@dhui
Copy link
Contributor

dhui commented Jan 14, 2018

Changes LGTM but the commit message is misleading. r doesn't designate a regex, it means it's a raw string. https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals

@dhui
Copy link
Contributor

dhui commented Jan 14, 2018

Looks like there's an issue w/ pylint_django, for which there are 2 proposed fixes:

Looks like pinning pylint to and older version will also help get around the issue: pylint-dev/pylint-django#108

@asherf asherf changed the title properly mark regex strings properly mark raw strings (used as regex) Jan 18, 2018
@asherf
Copy link
Contributor Author

asherf commented Jan 18, 2018

@dhui updated
stacked on top of #52

@dhui
Copy link
Contributor

dhui commented Jan 18, 2018

:shipit:

@asherf asherf merged commit 0b39494 into hearsaycorp:master Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asherf @dhui