Cache 'redbaron_classname_to_baron_type', giving ~30% performance boost on 'find_all' heavy code. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st on 'find_all' heavy code.
jtamagnan
reviewed
Apr 27, 2018
| @@ -19,7 +19,8 @@ | |||
| def baron_type_to_redbaron_classname(baron_type): | |||
| return "".join(map(lambda x: x.capitalize(), baron_type.split("_"))) + "Node" | |||
|
|
|||
|
|
|||
| from functools import lru_cache | |||
| @@ -19,7 +19,8 @@ | |||
| def baron_type_to_redbaron_classname(baron_type): | |||
| return "".join(map(lambda x: x.capitalize(), baron_type.split("_"))) + "Node" | |||
|
|
|||
|
|
|||
| from functools import lru_cache | |||
There was a problem hiding this comment.
functools.lru_cache is python3 only and will not work in python2. It might be easy to write a cache decorator with no max size:
def memoize(function):
memo = {}
@wraps(function)
def wrapper(*args):
if args in memo:
return memo[args]
else:
rv = function(*args)
memo[args] = rv
return rv
return wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low hanging fruit!