-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper dependency management #72
Comments
Almost done here. I had a look and i think we should move lmfit into plotting, because the fitting submodule only works with the plotting dependencies. And we could change the error message in the import of elli.fitting to hint at the pip install option. @domna Or should we try to separate fitting and the interactive widget? |
I think we can keep fitting and interactive widget together as these are not so many dependencies and at least for me I most often just use them together. But it's a good approach to hint the pip install option 👍️ |
@MarJMue I renamed the extra to fitting and put lmfit within there. I also updated the README to show how to install with the fitting extra as I think people most often want to use this capability. |
I am totally fine with this. Fitting without visualizing the data is not very sensible. I just wanted to ask. Everything else is 'advanced' use from my view and everyone doing should be able to build their environment themself. |
Introduce better dependency management to not run in any dependency issues.
Either use poetry, pipenv or specify version in requirements.txt with
pip freeze > requirements.txt
or add an additional requirements.freeze.txt.This includes offering better install options for the optional fitting part. I think we should have something like
pip install pyElli[fitting]
.The text was updated successfully, but these errors were encountered: