[Issue 168] Vectorized KKR internals #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A minor refactoring is using |
IruNikZe
changed the title
|
Of course! 👍 Thanks for the quick response |
Sure. I could also do a small release if you need this directly from the package or are you using this through a git install anyways? |
|
I can use it via Git, that's fine by now 👨💻 |
|
It would be super awesome if this feature could be released :D Thank you for your work. |
|
Hey @laarisyko, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages NumPy's broadcasting to speed up the computation of the Kramers-Kronig-Relationship by making most of the computations happen at C-level rather than inside the
for-loop that handles both odd and even case with an expensiveif.Doing so would even allow for a simple Numba-compilation to speed up the computations even further (given it is available at runtime).
It tackles this issue
Fixes #168