Use OIDC for publishing #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the publishing routine based on this guide.
Added features
Remarks
In principle it's also possible to upload each build to test.pypi to make it available. However, the setuptools scm version makes problems in this case because it always contains a localpart (
+g<hash>) which is not allowed for test.pypi. There are discussions for adapting this behaviour (pypa/setuptools-scm#455 and pypa/setuptools-scm#478). I decided for now that this feature is not really important for, so I removed it. Just wanted to mention it here in case we want to have it in the future.