-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing Error in ShapeBuilder.rect / convert_stroke_width #555
Comments
Thank you for reporting this @darioackermann! |
@all-contributors please add @darioackermann for bug |
I've put up a pull request to add @darioackermann! 🎉 |
I'm happy to help out. Will try to see if I can provide any substantial PR |
Wait: This library currently does not draw any |
Should have read the docs. It's quite clear there. That's a deal-breaker for us, sadly :( What I have found so far is that when parsing in Edit: I see that you do not currently (want to?) support relative values. I'll therefore only add a PR to use |
You are right. This fix hasn't been released yet: https://github.com/PyFPDF/fpdf2/blob/master/CHANGELOG.md#fixed
Not currently, but we are planning to implement them: #537
What kind of "relative values" are you refering to exactly? |
The second issue is resolved by the fix provided, thx 😊
That's awesome! Unfortunately I don't really know anything about SVG and how I'd convert text to a path.
The SVG file above uses % for the first rect definition, to fill its parent. This could be solved with moderate effort, but I'm not sure about all the other relative sizes. |
Closed by #558 |
Describe the bug
Error details
File "C:\Users\***\AppData\Local\Programs\Python\Python310\lib\site-packages\fpdf\svg.py", line 354, in rect width = float(tag.attrib.get("width", 0)) ValueError: could not convert string to float: '100%'
In a nutshell, it tries to convert an svg attribute
width="100%"
into float which fails.Minimal code
QRBill Library from here: https://github.com/claudep/swiss-qr-bill
test.svg
Environment
fpdf2
version: 2.5.7Done so far
I have wrapped the throwing statements in a try except block, then another error pops up:
which should be very much allowed
The text was updated successfully, but these errors were encountered: