-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use resolve_length in ShapeBuilder.rect #558
Use resolve_length in ShapeBuilder.rect #558
Conversation
Thank you for submitting a PR! |
Added a Test and documented in Changelog. Should there any change be necessary, just let me know. |
Your PR is fine but the GitHub Actions pipeline is currently blocked by #559 |
Sure, no stress! I'll watch #559 and rebase accordingly |
The issue #559 is fixed now |
Codecov ReportBase: 94.07% // Head: 94.07% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 94.07% 94.07%
=======================================
Files 21 21
Lines 6124 6124
Branches 1250 1250
=======================================
Hits 5761 5761
Misses 189 189
Partials 174 174 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I rebased and based your branch |
Thanks for rebasing, I was a bit short of time today. You're welcome! |
Provides a tiny fix to #555
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.