Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize ssl mode settings #475

Merged
merged 7 commits into from
May 15, 2023
Merged

Conversation

thereisnosun
Copy link
Contributor

According to https://mariadb.com/kb/en/mysql_optionsv/ MariaDB supports TLS enforcing in its own way. So the idea behind this PR is to keep the same interface for MariaDB based clients, but behind the scenes handle it accordingly.(MariaDB gets its own args set, instead of ssl_mode dict supported by MySQL).

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Patch and project coverage have no change.

Comparison is base (9953e50) 86.48% compared to head (25bc72c) 86.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   86.48%   86.48%           
=======================================
  Files           7        7           
  Lines         555      555           
=======================================
  Hits          480      480           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 25, 2021

This pull request introduces 1 alert when merging d497312 into 24aaa72 - view on LGTM.com

new alerts:

  • 1 for Implicit function declaration

Copy link

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very much interested in having something like the changes here committed to allow for using MariaDB with strict server certificate validation (the equivalent of VERIFY_IDENTITY) but I think the changes here as is have some issues.

If there's anything I can do to help here, or to open up a separate PR, I'd love to help out.

MySQLdb/_mysql.c Outdated Show resolved Hide resolved
MySQLdb/_mysql.c Outdated Show resolved Hide resolved
MySQLdb/_mysql.c Outdated Show resolved Hide resolved
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 2, 2022

This pull request introduces 1 alert when merging 6cdf275 into 6979a47 - view on LGTM.com

new alerts:

  • 1 for Implicit function declaration

@methane methane changed the title Add ability to customize ssl mode settings #474 Add ability to customize ssl mode settings May 15, 2023
@methane methane linked an issue May 15, 2023 that may be closed by this pull request
@methane methane merged commit abb139b into PyMySQL:main May 15, 2023
@mschoettle mschoettle mentioned this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to customize ssl mode settings
3 participants