Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for building on Windows #484

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Better support for building on Windows #484

merged 2 commits into from
Sep 3, 2021

Commits on Mar 8, 2021

  1. Better support for building on Windows 

    mysqlclient can be built against either the MySQL Connector/C or the
MariaDB Connector/C. Previously, which library was used was hardcoded in
setup_windows.py while the path to the library was in site.cfg. Now both
settings can be specified in site.cfg, as environment variables, or
auto-detected. If a client isn't specified but a connector path is, that
path will be searched for either mariadbclient.lib or mysqlclient.lib to set
the client type. If a client is specified but a connector path isn't, the
default path used by the pre-built .msi installers will be assumed. This
will probably be "C:\Program Files\MariaDB\MariaDB Connector C" for
mariadbclient and "C:\Program Files\MySQL\MySQL Connector C 6.1" for
mysqlclient ("C:\Program Files (x86)" will be used on 32-bit builds). If
neither client nor connector are specified, both client types will be checked
to see if the appropriate .lib file exists in the default connector
directory. These changes will allow users to install from source via pip
(if binary wheels aren't available) without having to clone this repo to edit
site.cfg. They can either install one of the connectors in the default
location or install it somewhere else and set the path in the
`MYSQLCLIENT_CONNECTOR` environment variable before installing.

One other slight change was to add additional install and library directories
for mariadbclient. This is because the pre-built connector binaries install
the needed files in `include` and `lib` whereas building from source
(like this repo's workflow does) leaves them in `include/mariadb` and
`lib/mariadb`.
    @sparkyb
    sparkyb committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    83ce631 View commit details
    Browse the repository at this point in the history

  2. Remove support for building against MySQL Connector/C on Windows 

    MySQL Connector/C is not longer published since 2017. New builds are always
done against MariaDB Connector/C. Dropping support for the deprecated
MySQL Connector simplifies the Windows build process.
    @sparkyb
    sparkyb committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    8d49297 View commit details
    Browse the repository at this point in the history