Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_character_set() sends "SET NAMES" always. #509

Merged
merged 3 commits into from
Oct 19, 2021
Merged

set_character_set() sends "SET NAMES" always. #509

merged 3 commits into from
Oct 19, 2021

Conversation

methane
Copy link
Member

@methane methane commented Oct 19, 2021

Fix: #504.

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #509 (3db340e) into main (3ee07a0) will increase coverage by 1.80%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   83.99%   85.79%   +1.80%     
==========================================
  Files           6        6              
  Lines         556      542      -14     
==========================================
- Hits          467      465       -2     
+ Misses         89       77      -12     
Impacted Files Coverage Δ
MySQLdb/connections.py 87.02% <80.00%> (+7.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee07a0...3db340e. Read the comment docs.

@methane methane merged commit dee7d88 into main Oct 19, 2021
@methane methane deleted the fix-504 branch October 19, 2021 04:11
@methane methane added this to the v2.1 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError when using mysql client 8.0 to connect to mysql server 5.7
1 participant