Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard results without converting them into Python objects. #601

Merged
merged 6 commits into from
May 16, 2023

Conversation

methane
Copy link
Member

@methane methane commented May 16, 2023

Fixes #560.

@methane methane force-pushed the discard-result branch 2 times, most recently from 23d77df to 1aa356b Compare May 16, 2023 16:02
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.16 🎉

Comparison is base (abb139b) 86.48% compared to head (d512d6a) 88.64%.

❗ Current head d512d6a differs from pull request most recent head 38e4442. Consider uploading reports for the commit 38e4442 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   86.48%   88.64%   +2.16%     
==========================================
  Files           7        7              
  Lines         555      555              
==========================================
+ Hits          480      492      +12     
+ Misses         75       63      -12     
Impacted Files Coverage Δ
src/MySQLdb/__init__.py 86.84% <ø> (ø)
src/MySQLdb/_exceptions.py 100.00% <ø> (ø)
src/MySQLdb/connections.py 87.40% <ø> (ø)
src/MySQLdb/converters.py 82.35% <ø> (ø)
src/MySQLdb/cursors.py 85.88% <ø> (ø)
src/MySQLdb/release.py 100.00% <ø> (ø)
src/MySQLdb/times.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@methane methane marked this pull request as ready for review May 16, 2023 16:51
@methane methane merged commit a2e9706 into PyMySQL:main May 16, 2023
@methane methane deleted the discard-result branch May 16, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseCursor#close(..) can exhaust the system memory
1 participant