Do not use MYSQL_OPT_RECONNECT as possible. #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
force-pushed
the
reduce-reconnect-warning
branch
from
23f54c3
to
e584de1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 7 7
Lines 548 548
=======================================
Hits 487 487
Misses 61 61
☔ View full report in Codecov by Sentry. |
methane
force-pushed
the
reduce-reconnect-warning
branch
from
c2fd767
to
976bd97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL 8.0.33+ shows deprecation warning to stderr.
So we avoid using it as possible.
In the future, we will deprecate
reconnectoption of theConnection.ping().