Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented sdist building method isn't working #810

Closed
2 tasks done
itamarst opened this issue Feb 16, 2022 · 5 comments · Fixed by #813
Closed
2 tasks done

Documented sdist building method isn't working #810

itamarst opened this issue Feb 16, 2022 · 5 comments · Fixed by #813
Labels
bug Something isn't working

Comments

@itamarst
Copy link
Contributor

Bug Description

In previous versions, e.g. 0.12.6, and as documented (https://maturin.rs/distribution.html), one could run maturin build --intepreter with no additional argument and it would create an sdist tarball.

With 0.12.9, however, I get an error:

$ maturin build --interpreter
error: The argument '--interpreter <INTERPRETER>' requires a value but none was supplied

Your Python version (python -V)

3.9.7

Your pip version (pip -V)

21.2.4

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

Add appropriate sdist metadata to pyproject.toml, then run maturin build --interpreter. With 0.12.6 it works, with 0.12.9 it doesn't.

@itamarst itamarst added the bug Something isn't working label Feb 16, 2022
@itamarst itamarst changed the title Document sdist building isn't working Documented sdist building method isn't working Feb 16, 2022
@messense
Copy link
Member

Thanks for reporting, looks like a regression from the clap 3.0 upgrade.

But I think using maturin build -i to build only sdist is kinda odd, and there is also a maturin sdist command. The problem with maturin build -i is that it assumes Python extension while maturin also supports building bin bindings which doesn't require Python at all.

@itamarst
Copy link
Contributor Author

AH, so this is a documentation issue, then. Specifically https://github.com/PyO3/maturin/blob/main/guide/src/distribution.md?plain=1#L14 should mention maturin sdist instead of what it says now.

@messense
Copy link
Member

@konstin What do you think? Do we still want to support building sdist-only via maturin build -i?

@konstin
Copy link
Member

konstin commented Feb 17, 2022

I have no strong opinions, except that I think that the docs should point to maturin sdist

messense added a commit that referenced this issue Feb 17, 2022
@messense
Copy link
Member

I've updated the docs. Let's keep this issue open until we remove or bring back support for maturin build -i.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants