Document binary and library in a single package by entrypoint workaround #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
konstin
changed the title
|
This is awesome! |
|
File path on Windows is ridiculously complicated, maybe we should simplify the test case to not assert file paths. |
|
The tests are passing now, i've removed checks for platforms with inconsistent behaviors. I think the current |
konstin
force-pushed
the
binary_and_library
branch
from
7a84ba1
to
cfcc8e2
Compare
bors bot
added a commit
that referenced
this pull request
Apr 16, 2023
1565: Document binary and library in a single package by entrypoint workaround r=messense a=konstin Inspired by #368 (comment) Preview: https://deploy-preview-1565--maturin-guide.netlify.app/bindings.html#both-binary-and-library CC `@nanthony007` Co-authored-by: konstin <[email protected]>
|
Build failed: |
|
bors retry looks like a network error: https://github.com/PyO3/maturin/actions/runs/4760507648/jobs/8460910927 |
bors bot
added a commit
that referenced
this pull request
Apr 25, 2023
1565: Document binary and library in a single package by entrypoint workaround r=messense a=konstin Inspired by #368 (comment) Preview: https://deploy-preview-1565--maturin-guide.netlify.app/bindings.html#both-binary-and-library CC `@nanthony007` Co-authored-by: konstin <[email protected]>
|
Build failed: |
|
bors r+ discovering more strange platform behavior as i go |
bors bot
added a commit
that referenced
this pull request
Apr 26, 2023
1565: Document binary and library in a single package by entrypoint workaround r=konstin a=konstin Inspired by #368 (comment) Preview: https://deploy-preview-1565--maturin-guide.netlify.app/bindings.html#both-binary-and-library CC `@nanthony007` Co-authored-by: konstin <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #368 (comment)
Preview: https://deploy-preview-1565--maturin-guide.netlify.app/bindings.html#both-binary-and-library
CC @nanthony007