Add trusted publisher support #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Manually tested in
|
|
bors r+ |
|
Build succeeded: |
konstin
reviewed
Apr 26, 2023
| ) -> (String, String) { | ||
| // API token from environment variable takes priority | ||
| if let Ok(token) = env::var("MATURIN_PYPI_TOKEN") { | ||
| return ("__token__".to_string(), token); | ||
| } | ||
|
|
||
| // Try to get a token via OIDC exchange | ||
| match resolve_pypi_token_via_oidc(registry_url) { |
There was a problem hiding this comment.
what happens if someone uses this with a registry that isn't pypi?
There was a problem hiding this comment.
It will print a failure warning, but we can certainly do better to not show a warning. I'll improve it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1575