Fix crashing on unknown platforms #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks, but usually we only allow crates.io dependencies, so we need to wait for a new |
|
@siepkes you can pin |
siepkes
force-pushed
the
unknown-platform-crash
branch
from
e02c714
to
6ed84f8
Compare
platform-info 2.0.1 has an issue which causes it to fail hard (i.e. panic) on unknown platforms.
siepkes
force-pushed
the
unknown-platform-crash
branch
from
6ed84f8
to
2309112
Compare
|
@T-256 Thanks for the heads-up! I've updated the PR. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform-infohas an issue which causes it to fail hard on unknown platforms. This issue was fixed in newer versions however the latest released version (2.0.1) does not have the fix in it.