fix: preserve workspace inherited dependencies when building binary

[HerringtonDarkholme]

I don't have enough context for the fix but it did build on my local machine.

Before:

After:

fix #1738

[netlify]

✅ Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	c85faa1
🔍 Latest deploy log	https://app.netlify.com/sites/maturin-guide/deploys/64dd953c2ceb870008876273
😎 Deploy Preview	https://deploy-preview-1739--maturin-guide.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[messense]

Thanks! I think the issue was

maturin/src/source_distribution.rs

Lines 274 to 276 in 4c3d5c2

	// See https://github.com/toml-rs/toml/issues/594
	dep_table.remove(&dep_name);
	dep_table[&dep_name] = workspace_dep;

remove(&dep_name) didn't not correctly remove [dependencies] xxx.workspace = true while it works fine for

[dependencies.xxx]
workspace = true
# other fields

[HerringtonDarkholme]

If I read the code correct,

maturin/src/source_distribution.rs

Lines 274 to 276 in 4c3d5c2

	// See https://github.com/toml-rs/toml/issues/594
	dep_table.remove(&dep_name);
	dep_table[&dep_name] = workspace_dep;

this line will only remove workspace deps that are not path deps, since it is inside this check.

maturin/src/source_distribution.rs

Lines 240 to 242 in 4c3d5c2

	// If a workspace inherited dependency isn't a path dep,
	// we need to replace `workspace = true` with its full requirement spec.
	if !known_path_deps.contains_key(&dep_name) {

However, ast-grep-core is a path dep. So it is not removed.
I wonder what is the desired behavior? Previously all the workspace deps will be removed.

The comment here also specifies that the workspace deps should be removed and have been converted into path deps.

maturin/src/source_distribution.rs

Lines 295 to 301 in 8364dd9

	if workspace_inherit {
	// Remove workspace inheritance now that we converted it into a path dependency
	dep_table[&dep_name]
	.as_table_like_mut()
	.unwrap()
	.remove("workspace");
	}

[messense]

Right, we need to remove all workspace = true because the main Cargo.toml in sdist can't refer to any workspace members because we have rewritten the project structure to put evey path dep in a subdirectory.

It's a bit fragile, I do want to stop doing that, just lift pyproject.toml to sdist top level and rewrite manifest-path instead.

[HerringtonDarkholme]

Thanks for the explanation!
By the way it's really a joy to read your code. Thanks for the project 😄