Use extension name as library name, instead of hardcoded 'native.so' #1918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for some conversation, I'm hoping to distribute an extension via CFFI, but it's a bit awkward integrating it with other projects when the library name is always
native.so
. It also makes it difficult to link against multiple.In this PR I've just slightly tweaked the generation bits to make the library name the same as the extension name, so instead of
native.so
it will have the same name as the outer extension folder. I'm tempted to make itlib<extension_name>.so
as it's not an importable python module, so seems like it should use the standard library prefix?partially fixes #1919