Add a global verbose option #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
konstin
commented
May 9, 2024
| @@ -94,6 +94,7 @@ pub struct CargoOptions { | |||
| pub ignore_rust_version: bool, | |||
|
|
|||
| /// Use verbose output (-vv very verbose/build.rs output) | |||
| // Note that this duplicates the global option, but clap seems to be fine with that. | |||
There was a problem hiding this comment.
This feels wrong but unfortunately i don't understand the cargo argument handling enough to solve this properly
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
konstin
force-pushed
the
konsti/global-verbose-option
branch
2 times, most recently
from
9c0a1c6
to
dced2b8
Compare
messense
force-pushed
the
konsti/global-verbose-option
branch
from
dced2b8
to
10ad37b
Compare
Debugging #2079 i realized that we currently require `RUST_LOG=debug` for users to debug issues like missing inclusions. I added a global counting `-v` flag. We currently use `-v` to configure cargo verbosity level. For simplicity, it now configures both at the same time. Fine-grained control is still possible by setting `RUST_LOG`. The levels: * Default: Show build information and `cargo build` output. * `-v`: Use `cargo build -v`. * `-vv`: Show debug logging and use `cargo build -vv`. * `-vvv`: Show trace logging. This can be extended to support a quiet option.
messense
force-pushed
the
konsti/global-verbose-option
branch
from
10ad37b
to
202636d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging #2079 i realized that we currently require
RUST_LOGfor users to debug issues like missing inclusions. I added a global counting-vflag to allow users to get more verbose logging from maturin to help them diagnose their problems.We currently use
-vto configure cargo verbosity level. For simplicity, it now configures both at the same time. Fine-grained control is still possible by settingRUST_LOG.The levels:
cargo buildoutput.-v: Usecargo build -v.-vv: Show debug logging and usecargo build -vv.-vvv: Show trace logging.This can be extended to support a quiet option.