Add Python::with_gil
#1037
Merged
Add Python::with_gil
#1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
requested changes
Jul 15, 2020
| # } | ||
| # } | ||
|
|
||
| #[pymethods] | ||
| impl UserModel { | ||
| pub fn set_variables(&mut self, var: Vec<f64>) -> PyResult<()> { | ||
| pub fn set_variables(&mut self, var: Vec<f64>) { |
There was a problem hiding this comment.
This method should take py: Python.
There was a problem hiding this comment.
I agree, but it's actually quite hard to solve.
The trait signature impl Model for UserModel has no way to pass a Python into the trait methods. The idea for this example is to show how to wrap a Rust trait which doesn't know anything about Python, so I don't think changing the trait definition is a solution either.
For now I would like to leave it as it is, but if we come up with a good idea how to clean this up later I would be happy to resolve it. (I'll create an issue so we remember this.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1019, this is a new
Python::with_gilAPI for executing a closure with the GIL.It avoids some of the potential panics introduced in #1036, and also might be "nicer" because the usual
acquire_gil(); gil.python()dance can be replaced by a singlewith_gilcall.I've updated some key examples in the documentation to use
with_gil, as I think it's probably better to encourage users to use this new API rather thanacquire_gil().