Fix MSRV CI to correctly use MSRV #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Gaynor <[email protected]>
davidhewitt
force-pushed
the
fix-msrv-ci
branch
2 times, most recently
from
264b1b0
to
5ba2c33
Compare
|
Thanks, that would have had me stumped 😅 |
davidhewitt
force-pushed
the
fix-msrv-ci
branch
4 times, most recently
from
2de3030
to
7b3dd68
Compare
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think without this setting the specified Rust version does not become the default, and I think #1204 may have broken MSRV support 😢