Make PyTimeAccess::get_fold() return bool instead of u8 #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
approved these changes
Jan 21, 2021
src/types/datetime.rs
Outdated
Comment on lines
228
to
229
| // TODO: Python's fold values must be either 0 or 1 as per Python documentation. Should we | ||
| // panic if they do, for whatever reason, fall outside that range? |
There was a problem hiding this comment.
I don't think we should cause panic here.
|
As this is another breaking change, I'm thinking it's time to release 0.13.2 before we then start merging all changes for 0.14 . Will put a PR for this out tonight. |
|
I'm rebasing and merging this shortly. Thanks again! |
davidhewitt
force-pushed
the
get_fold_bool
branch
2 times, most recently
from
0665222
to
87ee51f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fold property of a Python datetime stores whether the datetime lies on a leap second or not. The only allowed values are 0 and 1 (source). Therefore, the
PyTimeAccess::get_fold()method should expose this property as abool.Coincidentally, the
PyTime::new_with_fold()already uses bool as the type of fold.In a later PR, I will add the currently missing
PyDateTime::new_with_fold()method, which is also going to accept bool for the fold parameter.This is a breaking change