Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mingw platform detection #1993

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Fix mingw platform detection #1993

merged 1 commit into from
Nov 15, 2021

Conversation

messense
Copy link
Member

@messense messense commented Nov 15, 2021 •
edited
Loading

@messense messense mentioned this pull request Nov 15, 2021
Merged
davidhewitt
davidhewitt approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think this is worth a "Fixed" CHANGELOG entry please!

@davidhewitt davidhewitt merged commit 543f4c1 into PyO3:main Nov 15, 2021
@messense messense deleted the mingw branch November 15, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@messense @davidhewitt