Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Py<T>.setattr method #2009

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Add Py<T>.setattr method #2009

merged 1 commit into from
Nov 19, 2021

Conversation

vxgmichel
Copy link
Contributor

@vxgmichel vxgmichel commented Nov 19, 2021 •
edited
Loading

PyAny exposes a setattr method, but Py<T> currently doesn't.

TODO:

  • add Py::setattr method
  • add an entry in CHANGELOG.md
  • add the corresponding test

davidhewitt
davidhewitt approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@birkenfeld
Copy link
Member

It looks like there are other methods missing from Py. Should they get the same API in general?

@davidhewitt
Copy link
Member

Should they get the same API in general?

Probably, yes, though I hadn't been rushing to add to Py because I'm not yet sure how much needs to change with #1056.

@davidhewitt davidhewitt merged commit 3271b90 into PyO3:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vxgmichel @birkenfeld @davidhewitt