err: tweak names, inlining and docs #2026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a bunch of naming on the
PyErr
type:get_type
,value
andtraceback
as per Better names forPyErr::ptype
,PyErr::pvalue
andPyErr::ptraceback
#1987into_instance
->into_value
andfrom_instance
->from_value
).#[inline]
in a couple of places where it looked like it made sense. According tobench_err
this has made a slight improvement.PyErr::into_instance
(nowPyErr::into_value
) actually had a memory leak in it, which is now also fixed.Closes #1987