-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ToPyObject for [T; N] #2313
Conversation
CI failure is unrelated and affects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm not sure why this was missing. I suppose in most cases, like when calling the method on an array, it can find the &[T]
implementation - but inline-python
uses it in a generic context where this does not work.
|
This comment was marked as resolved.
This comment was marked as resolved.
It's already guarded by a feature flag, which is set by build.rs depending on version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I think this was just an accidental omission 👍
Rebasing on |
Thanks! |
It seems like this was forgotten to implement (unless there was a good reason not to implement this, which I did not find in my quick search).
Related: m-ou-se/inline-python#51