Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros: fix the check for applying METH_NOARGS #2760

Merged
merged 1 commit into from
Nov 20, 2022
Merged

macros: fix the check for applying METH_NOARGS #2760

merged 1 commit into from
Nov 20, 2022

Conversation

birkenfeld
Copy link
Member

to only consider the Python argument list.

Fixes #2750

@birkenfeld
macros: fix the check for applying METH_NOARGS
ea9da80 
to only consider the Python argument list.

Fixes #2750
davidhewitt
davidhewitt approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@davidhewitt davidhewitt merged commit d865367 into main Nov 20, 2022
@davidhewitt davidhewitt deleted the 2750-fix branch November 20, 2022 11:31
@davidhewitt davidhewitt restored the 2750-fix branch November 20, 2022 11:32
@davidhewitt davidhewitt deleted the 2750-fix branch November 20, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for "method has no arguments" considers py an argument
2 participants
@birkenfeld @davidhewitt