Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo DateType -> DateTimeType, fixes #3069 #3071

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

sollyucko
Copy link
Contributor

@sollyucko sollyucko commented Mar 27, 2023

This should fix #3069 AKA https://stackoverflow.com/questions/75857300/tell-if-object-isinstance-of-pydatetime-or-pydate. I've added an entry in newsfragments and I've added some regression tests in test_datetime.rs.

Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, it looks good! If you rebase on master, the CI failure should be gone.

@davidhewitt
Copy link
Member

👍 (squashing for a tidy git history at the same time appreciated though not required)

@sollyucko
Copy link
Contributor Author

sollyucko commented Mar 28, 2023

I've merged in master using GitHub's UI, and now the CI passes. Could you just "squash and merge", or should I squash my changes in my branch when I get to a CLI in a few hours?

@messense
Copy link
Member

Could you just "squash and merge"

bors doesn't support per-PR squash-merge.

@adamreichold
Copy link
Member

I manually force pushed the branch, let's give it a try:

bors r+

@sollyucko
Copy link
Contributor Author

Perfect, thanks!

@bors
Copy link
Contributor

bors bot commented Mar 28, 2023

Build succeeded:

  • conclusion

@bors bors bot merged commit 90d50da into PyO3:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datetime.date isinstance PyDateTime returns True?
5 participants