Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate PyIterator::from_object and PyByteArray::from from AsPyPointer to &PyAny #3389

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Migrate PyIterator::from_object and PyByteArray::from from AsPyPointer to &PyAny #3389

merged 1 commit into from
Aug 16, 2023

Conversation

alex
Copy link
Contributor

@alex alex commented Aug 15, 2023 •
edited
Loading

refs #3358

@alex alex mentioned this pull request Aug 15, 2023
Merged
davidhewitt
davidhewitt approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, as discussed on the issue, while this is direct breakage it should be relatively minor for most users and given the need to remove / minimize AsPyPointer I think it's prudent to accept this fallout without a deprecation dance.

@davidhewitt davidhewitt added this pull request to the merge queue Aug 15, 2023
Merged via the queue into PyO3:main with commit 82b1e55 Aug 16, 2023
31 checks passed
@alex alex deleted the less-as-py-pointer branch August 16, 2023 01:11
@davidhewitt davidhewitt mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex @davidhewitt