Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PyAnyMethods for binary operators #3712

Merged
merged 1 commit into from
Dec 30, 2023
Merged

add PyAnyMethods for binary operators #3712

merged 1 commit into from
Dec 30, 2023

Conversation

alex
Copy link
Contributor

@alex alex commented Dec 29, 2023

also pow

fixes #3709

@alex alex force-pushed the binops branch 2 times, most recently from b31fd11 to c734c6e Compare December 29, 2023 21:11
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some thoughts...

tests/test_arithmetics.rs Outdated Show resolved Hide resolved
src/types/any.rs Show resolved Hide resolved
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me! 🚀

@alex alex added this pull request to the merge queue Dec 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 30, 2023
@alex
Copy link
Contributor Author

alex commented Dec 30, 2023

Is that test known to be flakey? It doesn't look obviously related to this PR.

@adamreichold
Copy link
Member

Is that test known to be flakey? It doesn't look obviously related to this PR.

Not really and from looking at the source and running it locally, I cannot reproduce the failure on main. I did try to restart the CI job to see whether the failure is deterministic on this branch.

@adamreichold adamreichold added this pull request to the merge queue Dec 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 30, 2023
@alex
Copy link
Contributor Author

alex commented Dec 30, 2023

This failure was definitely a network flake :-(

@alex alex added this pull request to the merge queue Dec 30, 2023
Merged via the queue into PyO3:main with commit 54390bc Dec 30, 2023
37 checks passed
@alex alex deleted the binops branch December 30, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose binary operations (*, &, etc.)
3 participants