fix some nightly lints 2024-01-12 #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Jan 12, 2024
| .map(|p| p.value.0.clone()) | ||
| .unwrap_or_else(|| syn::parse_str("::pyo3").unwrap()) | ||
| match attr { | ||
| Some(attr) => attr.value.0.clone(), |
There was a problem hiding this comment.
Here nightly clippy didn't like the attr.as_ref().map(|attr| attr.value.0.clone()) and wanted attr.clone(), but I don't agree with that, because it's cloning more data than necessary.
There was a problem hiding this comment.
The new lint is way overly aggressive: rust-lang/rust-clippy#12135
There was a problem hiding this comment.
Agreed, it seems a bit broken. Thanks for filing that upstream 👍
|
Will just set this to merge and hope it goes in. |
CodSpeed Performance ReportMerging #3738 will degrade performances by 18.05%Comparing Summary
Benchmarks breakdown
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
davidhewitt
force-pushed
the
nightly-lints
branch
from
7b28e26
to
4504a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lints are firing on latest nightly versions; hopefully this fixes them!