Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AsRef impls for PyBackedStr and PyBackedBytes #3991

Merged
merged 2 commits into from
Mar 25, 2024
Merged

add AsRef impls for PyBackedStr and PyBackedBytes #3991

merged 2 commits into from
Mar 25, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Mar 25, 2024

Following from #3990 (comment)

This adds AsRef implementations for PyBackedStr and PyBackedBytes

@adamreichold
Copy link
Member

adamreichold commented Mar 25, 2024 •
edited
Loading

I think we need to suppress the dead_code lint in our macro output for this to pass on Nightly.

@davidhewitt
Copy link
Member

Think the nightly lint is unrelated churn, happy to move ahead with this as-is, can fix that in another PR. Thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Mar 25, 2024
Merged via the queue into PyO3:main with commit 54ffaec Mar 25, 2024
41 of 43 checks passed
@Icxolu Icxolu deleted the pybacked-asref branch March 25, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Icxolu @adamreichold @davidhewitt