-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add import_exception_bound!
macro
#4027
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think there's a syntax error or something somewhere:
|
davidhewitt
force-pushed
the
import-exception
branch
from
March 30, 2024 23:18
33371a4
to
7209b17
Compare
Ugh, sorry, force-pushed and actually moved some tests over to it now 🤦 |
Ok, local check looks good, pushing to CI for coverage. |
Yeah, looks green pyca/cryptography#10671 |
alex
reviewed
Mar 30, 2024
Great! |
alex
approved these changes
Mar 31, 2024
CodSpeed Performance ReportMerging #4027 will improve performances by 24.29%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3989
The idea here is that this macro implements only the traits needed to use an imported exception inside a
Bound
(and not as a GIL Ref). This should help with coverage.cc @alex - want to give this a try?