Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support pyclass on tuple enums #4072

Merged
merged 24 commits into from
May 17, 2024
Merged

feat: support pyclass on tuple enums #4072

merged 24 commits into from
May 17, 2024

Commits on May 16, 2024

  1. feat: support pyclass on tuple enums

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4960de3 View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    53c95f6 View commit details
    Browse the repository at this point in the history

  3. changelog

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e051a5f View commit details
    Browse the repository at this point in the history

  4. ruff format

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    eaf5265 View commit details
    Browse the repository at this point in the history

  5. rebase with adaptation for FnArg refactor

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    51d434f View commit details
    Browse the repository at this point in the history

  6. fix class.md from pr comments

    @carderne @newcomertv
    carderne authored and newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9c540ed View commit details
    Browse the repository at this point in the history

  7. add enum tuple variant getitem implementation

    @carderne @newcomertv
    carderne authored and newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7b06fe5 View commit details
    Browse the repository at this point in the history

  8. fmt

    @carderne @newcomertv
    carderne authored and newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3c48775 View commit details
    Browse the repository at this point in the history

  9. progress toward getitem and len impl on derive pyclass for complex en… 

    …um tuple
    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a2f582c View commit details
    Browse the repository at this point in the history

  10. working getitem and len slots for complex tuple enum pyclass derivation

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d72a893 View commit details
    Browse the repository at this point in the history

  11. refactor code generation

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    13aa7a0 View commit details
    Browse the repository at this point in the history

  12. address PR concerns 

    - take py from function argument on get_item
- make more general slot def implementation
- remove unnecessary function arguments
- add testcases for uncovered cases including future feature match_args
    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    47cd6ce View commit details
    Browse the repository at this point in the history

  13. add tracking issue

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    07710d3 View commit details
    Browse the repository at this point in the history

  14. fmt

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    94da194 View commit details
    Browse the repository at this point in the history

  15. ruff

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    1921898 View commit details
    Browse the repository at this point in the history

  16. remove me

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    41a33ea View commit details
    Browse the repository at this point in the history

  17. support match_args for tuple enum

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    91c457f View commit details
    Browse the repository at this point in the history

  18. integrate FnArg now takes Cow

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9ae0a48 View commit details
    Browse the repository at this point in the history

  19. fix empty and single element tuples

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    73b7a8f View commit details
    Browse the repository at this point in the history

  20. use impl_py_slot_def for cimplex tuple enum slots

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5bd5690 View commit details
    Browse the repository at this point in the history

  21. reverse erroneous doc change

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    78d5078 View commit details
    Browse the repository at this point in the history

  22. Address latest comments

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0761854 View commit details
    Browse the repository at this point in the history

  23. formatting suggestion

    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7dd1a93 View commit details
    Browse the repository at this point in the history

  24. fix : 

    - clippy beta
- better compile error (+related doc and test)
    @newcomertv
    newcomertv committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6d7596e View commit details
    Browse the repository at this point in the history