ci: check minimal-versions on MSRV feature powerset #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
minimal-versions
branch
from
8649354
to
36220a2
Compare
davidhewitt
force-pushed
the
minimal-versions
branch
from
a524fc9
to
6cc3b77
Compare
|
If no concerns I'll probably merge this soon given it improves end user packaging slightly. |
davidhewitt
added a commit
that referenced
this pull request
Jul 10, 2024
* ci: check minimal-versions on MSRV feature powerset * fix msrv arg * bump num-bigint floor to 0.4.2 * try fix build syntax
davidhewitt
added a commit
that referenced
this pull request
Jul 16, 2024
* ci: check minimal-versions on MSRV feature powerset * fix msrv arg * bump num-bigint floor to 0.4.2 * try fix build syntax
davidhewitt
added a commit
that referenced
this pull request
Jul 17, 2024
* ci: check minimal-versions on MSRV feature powerset * fix msrv arg * bump num-bigint floor to 0.4.2 * try fix build syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #4272
Using
cargo update -Z direct-minimal-versions(orcargo update -Z minimal-versions) is known to be complicated. I started playing with these and had not much success due to various combinations of dev dependencies and other edge cases.cargo-minimal-versionsworked great, however, and given it's a superset aroundcargo-hackwhich we already use in thecheck-feature-powersetjob, I decided to just upgrade that job a bit to run a minimal-versions check on MSRV.This caught a few extra cases where our minimal dependencies were too low.