Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully remove the rest of the gil-refs #4378

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fully remove the rest of the gil-refs #4378

merged 2 commits into from
Jul 26, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Jul 25, 2024

This fully removes the rest of the gil-refs API including the cargo feature. cfg-cfg made it really easy to find all the remaining usages 🎊

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Jul 25, 2024
LilyFoote
LilyFoote approved these changes Jul 26, 2024
View reviewed changes
pyo3-macros-backend/src/pyclass.rs Show resolved Hide resolved
src/gil.rs Show resolved Hide resolved
davidhewitt
davidhewitt approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ace, lovely purging of old code! Next step I guess is for us to get those new method names done again :)

@davidhewitt davidhewitt added this pull request to the merge queue Jul 26, 2024
@davidhewitt davidhewitt removed this pull request from the merge queue due to a manual request Jul 26, 2024
@davidhewitt
Copy link
Member

Oh actually quick thought - this one might be worth having a note down as a "removed deprecated gil-refs feature" entry in the CHANGELOG?

@Icxolu
Copy link
Contributor Author

Icxolu commented Jul 26, 2024

Thanks both for the review!

Oh actually quick thought - this one might be worth having a note down as a "removed deprecated gil-refs feature" entry in the CHANGELOG?

Sure, I'll add that and then proceed to merge 👍

@Icxolu Icxolu removed the CI-skip-changelog Skip checking changelog entry label Jul 26, 2024
@Icxolu Icxolu enabled auto-merge July 26, 2024 16:22
@Icxolu Icxolu added this pull request to the merge queue Jul 26, 2024
Merged via the queue into PyO3:main with commit 1ca484d Jul 26, 2024
42 of 43 checks passed
@Icxolu Icxolu deleted the gil-ref-removal branch July 26, 2024 17:23
@davidhewitt davidhewitt mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

@LilyFoote LilyFoote LilyFoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Icxolu @davidhewitt @LilyFoote