fix incorrect spans on ret and py local varianbles in emitted code
#4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
approved these changes
Jul 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
davidhewitt
pushed a commit
that referenced
this pull request
Sep 3, 2024
#4382) * fix incorrect spans on `ret` and `py` local varianbles in emitted code * add newsfragment
davidhewitt
pushed a commit
that referenced
this pull request
Sep 15, 2024
#4382) * fix incorrect spans on `ret` and `py` local varianbles in emitted code * add newsfragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the new
output_span(#4220) of the return type of functions and methods (ret) is not carried to every usage, and the span ofpyinmap_result_into_ptrhas incorrectly changed.Closes #4381