-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nightly ci #4385
fix nightly ci #4385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -149,7 +149,10 @@ macro_rules! pyobject_native_type_named ( | |||
#[macro_export] | |||
macro_rules! pyobject_native_static_type_object( | |||
($typeobject:expr) => { | |||
|_py| unsafe { ::std::ptr::addr_of_mut!($typeobject) } | |||
|_py| { | |||
#[allow(unused_unsafe)] // https://github.com/rust-lang/rust/pull/125834 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah great, so it looks like one day we won't need the allow
at all. Great investigation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably gonna be a while until we're at MSRV 1.82, but eventually is better than never 😆
Fix nightly to unblock merges