Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore _PyLong_NumBits on Python 3.13 and later #4450

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

exg
Copy link
Contributor

@exg exg commented Aug 18, 2024

See python/cpython@cc663b7

Thank you for contributing to PyO3!

By submitting these contributions you agree for them to be dual-licensed under PyO3's MIT OR Apache-2.0 license.

Please consider adding the following to your pull request:

  • an entry for this PR in newsfragments - see [https://pyo3.rs/main/contributing.html#documenting-changes]
    • or start the PR title with docs: if this is a docs-only change to skip the check
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

PyO3's CI pipeline will check your pull request, thus make sure you have checked the Contributing.md guidelines. To run most of its tests
locally, you can run nox. See nox --list-sessions
for a list of supported actions.

@davidhewitt
Copy link
Member

Xref #4379

While the general trend is to take _Py symbols out of the public API, in this case the CPython devs seem to have agreed to keep this around for now (and I was planning to re-expose in #4379 too).

Thanks 👍

@davidhewitt davidhewitt added this pull request to the merge queue Aug 18, 2024
Merged via the queue into PyO3:main with commit 57d85b1 Aug 18, 2024
41 checks passed
@exg exg deleted the PyLong_NumBits branch August 18, 2024 12:39
@exg
Copy link
Contributor Author

exg commented Sep 16, 2024

@davidhewitt I have been waiting for a new pyo3 release with this change in order to make a new ormsgpack release with python 3.13 support. Alas, pyo3 0.22.3 does not include it. Would it by chance be possible to backport the change to the release-0.22 branch and make a new release?

@davidhewitt
Copy link
Member

Thanks for the ping. I think I will need to put out a 0.22.4 patch with #4563 so I will include this at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants