Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type_object: fix new clippy complaint about length of doc comment #4527

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

birkenfeld
Copy link
Member

@birkenfeld birkenfeld commented Sep 4, 2024

On beta/nightly:

warning: first doc comment paragraph is too long
  --> src/type_object.rs:19:1
   |
19 | / /// `T: PySizedLayout<U>` represents that `T` is not a instance of
20 | | /// [`PyVarObject`](https://docs.python.org/3.8/c-api/structures.html?highlight=pyvarobject#c.PyVarObject).
21 | | /// In addition, that `T` is a concrete representation of `U`.
   | |_
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
   = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default

@birkenfeld birkenfeld added the CI-skip-changelog Skip checking changelog entry label Sep 4, 2024
@birkenfeld
Copy link
Member Author

I lumped another very minor fix in this...

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 3d5d408 Sep 4, 2024
42 of 43 checks passed
@davidhewitt davidhewitt deleted the clippy-fix branch September 4, 2024 11:19
davidhewitt pushed a commit that referenced this pull request Sep 13, 2024
)

* type_object: fix new clippy complaint about length of doc comment

* all: replace minor version specific links to CPython docs
davidhewitt pushed a commit that referenced this pull request Sep 15, 2024
)

* type_object: fix new clippy complaint about length of doc comment

* all: replace minor version specific links to CPython docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants