Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FFI bindings to reflect deprecated and removed items #4534

Merged
merged 4 commits into from
Sep 7, 2024

Conversation

ngoldbaum
Copy link
Contributor

@ngoldbaum ngoldbaum commented Sep 5, 2024

These were all found by grepping for Py_DEPRECATED in the CPython Include directory.

Besides noting that I removed _PyErr_ChainExceptions, should I add a changelog entry explicitly mentioning all the things I'm newly marking as deprecated? Or just say I updated the FFI to match the state of the CPython headers in 3.13 WRT deprecated and removed things?

@davidhewitt
Copy link
Member

Thanks for doing this!

It looks like in the past that I just did a blanket statement rather than mention them all individually for the deprecations.

Worth calling out the removal separately.

pyo3-ffi/src/ceval.rs Outdated Show resolved Hide resolved
Co-authored-by: Lily Foote <[email protected]>
Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #4534 will not alter performance

Comparing ngoldbaum:update-deprecated (2633e19) with main (bf16238)

🎉 Hooray! pytest-codspeed just leveled up to 2.2.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 82 untouched benchmarks

@LilyFoote LilyFoote added this pull request to the merge queue Sep 6, 2024
Merged via the queue into PyO3:main with commit ae2fb49 Sep 7, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants